Conversation
Baltoli
force-pushed
the
bruce/simulate-2
branch
from
dfb0b09 to
37d6533
Compare
dhil
force-pushed
the
bruce/simulate-2
branch
6 times, most recently
from
84c6a5b to
aeb35e7
Compare
dhil
force-pushed
the
bruce/simulate-2
branch
3 times, most recently
from
fbea3c9 to
727852d
Compare
dhil
force-pushed
the
bruce/simulate-2
branch
4 times, most recently
from
b89f307 to
01cde5a
Compare
dhil
force-pushed
the
bruce/simulate-2
branch
12 times, most recently
from
fe068a5 to
017f012
Compare
dhil
force-pushed
the
bruce/simulate-2
branch
4 times, most recently
from
d41b673 to
be457a9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Baltoli
requested review from
Chen-Yifan,
goodlyrottenapple,
jhunsaker and
kkuehlz
dhil
force-pushed
the
bruce/simulate-2
branch
2 times, most recently
from
b17963e to
352d888
Compare
dhil
force-pushed
the
bruce/simulate-2
branch
5 times, most recently
from
3ee5e52 to
d954180
Compare
Contributor
|
@claude Please do another detailed re-review of this PR, taking into account unresolved and resolved comments from previous reviews and responses. Please consider the PR commit by commit; we want each commit be sound and coherent. |
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
|
P3 Mutually-exclusive state-override fields not enforced. Wont fix. |
dhil
force-pushed
the
bruce/simulate-2
branch
2 times, most recently
from
5615737 to
ce04d1b
Compare
Contributor
|
@claude please review this PR again. This time focus on identifying opportunities for data races, deadlocks, livelocks, or other parallel and concurrency-related bugs introduced by this PR. |
This comment was marked as resolved.
This comment was marked as resolved.
This patch adds two small container abstractions to the C API for handling arrays of state overrides and block overrides for the `eth_simulateV1` RPC endpoint. These containers are C++ allocated fixed sized arrays. Allocating the container structures in C++ ensure that we can guarantee safe construction and well-defined use of overrides. In particular, this means in BFT we do not need to rely on the definition of Rust's `Vec` to correctly pass contiguous data between execution and BFT.
This patch adds an abstraction to help the implementation of `eth_simulateV1` to manage the rolling context window used to check for reserve balance violations. Co-authored-by: Bruce Collie <[email protected]>
This patch adds an abstraction to help the implementation of `eth_simulateV1` to maintain a mixed buffer of finalized block hashes and simulated block hashes such that a `BLOCKHASH` invocation in a later simulated block can be correctly computed.
This patch extends the C interface of `monad_executor` with a submission procedure for `eth_simulateV1`. Currently, the procedure is not wired up to an implementation of `eth_simulateV1`. Co-authored-by: Bruce Collie <[email protected]>
This patch adds the core implementation of the `eth_simulateV1` RPC endpoint.
This patch wires the `eth_simulateV1` implementation up to the native transfers tracing mechanism. It does so by threading a boolean through the execution stack. This boolean is ultimately passed to `EvmcHost` to toggle emission of transfer traces.
This patch implements the interop layer for Rust <-> C for interacting with the `eth_simulateV1` implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on:
eth_simulatev1#2057eth_simulateV1#1926(commits should be rebased out when those PRs are merged)